Changeset b78996 in git

Timestamp:

Apr 14, 2011, 3:34:10 PM (12 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'a800fe4b3e9d37a38c5a10cc0ae9dfa0c15a4ee6')

Children:

a665ebdc0e6f023769cadc08a35bd0eb3f3ad935

Parents:

2f5936105b139a5635034b6eb233c5405b3e3e29

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2011-04-14 15:34:10+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 12:30:32+01:00

Message:

FIX: strting to fix sparse matrices (sparsmat.{h, cc})

Location:

libpolys/polys

Files:

• matpol.cc (modified) (7 diffs)
• simpleideals.h (modified) (1 diff)
• sparsmat.cc (modified) (10 diffs)
• sparsmat.h (modified) (1 diff)

libpolys/polys/matpol.cc

@@ -30 +30 @@
 #include "monomials/ring.h"
 #include "monomials/p_polys.h"
-// #include <kernel/sparsmat.h>
 
 #include "coeffrings.h"
@@ -365 +364 @@
   int       *qrow, *qcol;
   poly      *Xarray;
-  ring      _R;
+  const ring      _R;
   
   void mpInitMat();
@@ -1094 +1093 @@
         if (ap[jj] != NULL)
         {
-          q2 = SM_MULT(ap[jj], elim, div);
+          q2 = SM_MULT(ap[jj], elim, div, _R);
           if (a[jj] != NULL)
           {
-            q1 = SM_MULT(a[jj], piv, div);
+            q1 = SM_MULT(a[jj], piv, div, _R);
             p_Delete(&a[jj], _R);
             q2 = p_Add_q(q2, q1, _R);
@@ -1104 +1103 @@
         else if (a[jj] != NULL)
         {
-          q2 = SM_MULT(a[jj], piv, div);
+          q2 = SM_MULT(a[jj], piv, div, _R);
         }
         if ((q2!=NULL) && div)
-          SM_DIV(q2, div);
+          SM_DIV(q2, div, _R);
         a[jj] = q2;
       }
@@ -1119 +1118 @@
         if (a[jj] != NULL)
         {
-          q2 = SM_MULT(a[jj], piv, div);
+          q2 = SM_MULT(a[jj], piv, div, _R);
           p_Delete(&a[jj], _R);
           if (div)
-            SM_DIV(q2, div);
+            SM_DIV(q2, div, _R);
           a[jj] = q2;
         }
@@ -1839 +1838 @@
         if (a[j] != NULL)
         {
-          q1 = SM_MULT(a[j], piv, div);
+          q1 = SM_MULT(a[j], piv, div, _R);
           if (ap[j] != NULL)
           {
-            q2 = SM_MULT(ap[j], elim, div);
+            q2 = SM_MULT(ap[j], elim, div, _R);
             q1 = p_Add_q(q1,q2, _R);
           }
         }
         else if (ap[j] != NULL)
-          q1 = SM_MULT(ap[j], elim, div);
+          q1 = SM_MULT(ap[j], elim, div, _R);
         if (q1 != NULL)
         {
           if (div)
-            SM_DIV(q1, div);
+            SM_DIV(q1, div, _R);
           q[j] = q1;
         }
@@ -1862 +1861 @@
         if (a[j] != NULL)
         {
-          q1 = SM_MULT(a[j], piv, div);
+          q1 = SM_MULT(a[j], piv, div, _R);
           if (div)
-            SM_DIV(q1, div);
+            SM_DIV(q1, div, _R);
           q[j] = q1;
         }

libpolys/polys/simpleideals.h

@@ -8 +8 @@
 * ABSTRACT - all basic methods to manipulate ideals
 */
+#include <omalloc/omalloc.h>
 #include <polys/monomials/ring.h>
-#include <omalloc/omalloc.h>
 
 struct sip_sideal

libpolys/polys/sparsmat.cc

@@ -8 +8 @@
 */
 
-#include <kernel/mod2.h>
-#include <kernel/options.h>
-#include <kernel/febase.h>
-#include <kernel/intvec.h>
-#include <kernel/ring.h>
-#include <kernel/polys.h>
-#include <kernel/ideals.h>
-#include <kernel/numbers.h>
-#include <kernel/sparsmat.h>
-#include <kernel/prCopy.h>
-#include <kernel/p_Procs.h>
-#include <kernel/kbuckets.h>
-#include <kernel/p_Mult_q.h>
+#include "config.h"
+#include <misc/auxiliary.h>
+
+#include <omalloc/omalloc.h>
+#include <misc/mylimits.h>
+
+#include <misc/options.h>
+
+#include <reporter/reporter.h>
+#include <misc/intvec.h>
+
+#include <coeffs/numbers.h>
+#include "coeffrings.h"
+
+#include "monomials/ring.h"
+#include "monomials/p_polys.h"
+
+#include "simpleideals.h"
+
+
+#include "sparsmat.h"
+#include "prCopy.h"
+
+#include "templates/p_Procs.h"
+
+#include "kbuckets.h"
+#include "operations/p_Mult_q.h"
 
 // define SM_NO_BUCKETS, if sparsemat stuff should not use buckets
@@ -67 +81 @@
 
 static poly pp_Mult_Coeff_mm_DivSelect_MultDiv(poly p, int &lp, poly m,
-                                               poly a, poly b)
+                                               poly a, poly b, const ring currRing)
 {
   if (rOrd_is_Comp_dp(currRing) && currRing->ExpL_Size > 2)
@@ -83 +97 @@
   {
     p = pp_Mult_Coeff_mm_DivSelect(p, lp, m, currRing);
-    smExpMultDiv(p, a, b);
+    sm_ExpMultDiv(p, a, b, currRing);
   }
   return p;
 }
 
-static poly smSelectCopy_ExpMultDiv(poly p, poly m, poly a, poly b)
+static poly sm_SelectCopy_ExpMultDiv(poly p, poly m, poly a, poly b, const ring currRing)
 {
   int lp = 0;
-  return pp_Mult_Coeff_mm_DivSelect_MultDiv(p, lp, m, a, b);
+  return pp_Mult_Coeff_mm_DivSelect_MultDiv(p, lp, m, a, b, currRing);
 }
 
@@ -133 +147 @@
   smpoly piv, oldpiv;  // pivot and previous pivot
   smpoly dumm;         // allocated dummy
+  const ring _R;
+  
   void smColToRow();
   void smRowToCol();
@@ -157 +173 @@
   void smNormalize();
 public:
-  sparse_mat(ideal);
+  sparse_mat(ideal, const ring);
   ~sparse_mat();
   int smGetSign() { return sign; }
@@ -175 +191 @@
 */
 static void smMinSelect(long *, int, int);
-long smExpBound( ideal m, int di, int ra, int t)
+
+long sm_ExpBound( ideal m, int di, int ra, int t, const ring currRing)
 {
   poly p;
@@ -193 +210 @@
     while(p!=NULL)
     {
-      k = pGetComp(p)-1;
+      k = p_GetComp(p, currRing)-1;
       kr = r[k];
-      for (j=pVariables;j>0;j--)
-      {
-        if(pGetExp(p,j)>kc)
-          kc=pGetExp(p,j);
-        if(pGetExp(p,j)>kr)
-          kr=pGetExp(p,j);
+      for (j=rVar(currRing);j>0;j--)
+      {
+        if(p_GetExp(p,j, currRing)>kc)
+          kc=p_GetExp(p,j, currRing);
+        if(p_GetExp(p,j, currRing)>kr)
+          kr=p_GetExp(p,j, currRing);
       }
       r[k] = kr;
@@ -244 +261 @@
 
 /* ----------------- ops with rings ------------------ */
-ring smRingChange(ring *origR, long bound)
-{
-  *origR =currRing;
+ring sm_RingChange(const ring currRing, long bound)
+{
+//  *origR =currRing;
   ring tmpR=rCopy0(currRing,FALSE,FALSE);
   int *ord=(int*)omAlloc0(3*sizeof(int));
@@ -268 +285 @@
   if ((*origR)->qideal!=NULL)
   {
-    tmpR->qideal= idrCopyR_NoSort((*origR)->qideal, (*origR), tmpR);
-  }
-  rChangeCurrRing(tmpR);
+    tmpR->qideal= idrCopyR_NoSort((*origR)->qideal, currRing, tmpR);
+  }
+//  rChangeCurrRing(tmpR);
   if (TEST_OPT_PROT)
     Print("[%ld:%d]", (long) tmpR->bitmask, tmpR->ExpL_Size);
@@ -276 +293 @@
 }
 
-void smKillModifiedRing(ring r)
+void sm_KillModifiedRing(ring r)
 {
   if (r->qideal!=NULL) id_Delete(&(r->qideal),r);

libpolys/polys/sparsmat.h

@@ -11 +11 @@
 
 
-poly smMult(poly, poly);
-void smPolyDiv(poly, poly);
-poly smMultDiv(poly, poly, const poly);
-void smSpecialPolyDiv(poly, poly);
+poly sm_Mult(poly, poly, const ring);
+void sm_PolyDiv(poly, poly, const ring);
+poly sm_MultDiv(poly, poly, const poly, const ring);
+void sm_SpecialPolyDiv(poly, poly, const ring);
 /* ----------------- macros ------------------ */
 /* #define OLD_DIV 1 */
 
 #ifdef OLD_DIV
-#define SM_MULT(A,B,C) smMult(A,B)
-#define SM_DIV smPolyDiv
+#define SM_MULT(A,B,C, R) sm_Mult(A,B,R)
+#define SM_DIV sm_PolyDiv
 #else
-#define SM_MULT smMultDiv
-#define SM_DIV smSpecialPolyDiv
+#define SM_MULT sm_MultDiv
+#define SM_DIV sm_SpecialPolyDiv
 #endif
 
-poly smCallDet(ideal I);
-void smCallBareiss(ideal smat, int x, int y, ideal & M, intvec ** iv);
-ideal smCallSolv(ideal I);
+poly sm_CallDet(ideal I, const ring);
+void sm_CallBareiss(ideal smat, int x, int y, ideal & M, intvec ** iv, const ring);
+ideal sm_CallSolv(ideal I, const ring);
 
-ring smRingChange(ring *, long);
-void smKillModifiedRing(ring r);
-long smExpBound(ideal, int, int, int);
-BOOLEAN smCheckDet(ideal, int, BOOLEAN);
+ring sm_RingChange(const ring, long);
+void sm_KillModifiedRing(ring r);
+long sm_ExpBound(ideal, int, int, int, const ring);
+BOOLEAN sm_CheckDet(ideal, int, BOOLEAN, const ring);
 #endif