Changeset bcfd11a in git for libpolys/polys/monomials/ring.h

Timestamp:

Mar 20, 2012, 3:33:34 PM (11 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', 'd1ba061a762c62d3a25159d8da8b6e17332291fa')

Children:

7e9f1298826e9e80c154aaa465935c0ba2acad38

Parents:

dd668fd21e0141dd6716d45d63f34e6ca84d230f

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-03-20 15:33:34+01:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-03-23 16:06:34+01:00

Message:

elimination of rMinpolyIsNULL in favour of nCoeff_is_algExt

fix rMinpolyIsNULL (idIs0)

TODO: remove rMinpolyIsNULL it completely!

File:

• libpolys/polys/monomials/ring.h (modified) (1 diff)

libpolys/polys/monomials/ring.h

@@ -649 +649 @@
 
 /// Tests whether '(r->cf->minpoly) == NULL'
-BOOLEAN rMinpolyIsNULL(const ring r);
+static inline BOOLEAN rMinpolyIsNULL(const ring r)
+{
+  assume(r != NULL);
+  const coeffs C = r->cf;
+  assume(C != NULL);
+
+  const BOOLEAN ret = nCoeff_is_algExt(C); //  || nCoeff_is_GF(C) || nCoeff_is_long_C(C);
+
+  if( ret )
+  {
+    const ring R = C->extRing;
+    assume( R != NULL );
+    BOOLEAN idIs0 (ideal h);
+    assume( !idIs0(R->qideal) );
+  }
+
+  // TODO: this leads to test fails (due to rDecompose?)
+  return !ret;
+}
+