Changeset bf876a in git for kernel

Timestamp:

Aug 17, 2022, 1:53:24 PM (20 months ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '4a9821a93ffdc22a6696668bd4f6b8c9de3e6c5f')

Children:

526e5cde24eb73ac4ecfe282cdfceca1b3f64954

Parents:

3d17e66f2ca42d1b7e7dc513828600e9b7609ec9

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2022-08-17 13:53:24+02:00

git-committer:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2022-08-17 13:57:23+02:00

Message:

fix: redMotraNFRing (use ndQuotRem, n_DivBy,..)

File:

• kernel/GBEngine/kstd1.cc (modified) (5 diffs)

kernel/GBEngine/kstd1.cc

@@ -581 +581 @@
     h->SetShortExpVector();
     if ((strat->tl>=0)
-    &&strat->T[0].GetpFDeg() == 0 
+    &&strat->T[0].GetpFDeg() == 0
     && strat->T[0].length <= 2)
     {
@@ -1080 +1080 @@
     H.p = h;
     int j0, j = 0;
-    int z = 10;
     int docoeffred  = 0;
     poly T0p    = strat->T[0].p;
@@ -1089 +1088 @@
     H.sev = pGetShortExpVector(H.p);
     unsigned long not_sev = ~ H.sev;
-    if (strat->T[0].GetpFDeg() == 0 && strat->T[0].length <= 2) {
-        docoeffred  = 1;
+    if (strat->T[0].GetpFDeg() == 0 && strat->T[0].length <= 2)
+    {
+        docoeffred  = 1; // euclidean ring required: n_QuotRem
+        if (currRing->cf->cfQuotRem==ndQuotRem)
+        {
+          docoeffred = 0;
+        }
     }
     loop
@@ -1097 +1101 @@
          * T[0] is 0 (constant). This is only efficient if T[0] is short, thus
          * we ask for the length of T[0] to be <= 2 */
-        if (docoeffred) {
+        if (docoeffred)
+        {
             j0 = kTestDivisibleByT0_Z(strat, &H);
-            if (j0 == 0 && n_DivBy(pGetCoeff(H.p), pGetCoeff(T0p), currRing->cf) == FALSE
-                    && T0ecart <= H.ecart) {
+            if ((j0 == 0)
+            && (n_DivBy(pGetCoeff(H.p), pGetCoeff(T0p), currRing->cf) == FALSE)
+            && (T0ecart <= H.ecart))
+            {
                 /* not(lc(reducer) | lc(poly)) && not(lc(poly) | lc(reducer))
                  * => we try to cut down the lead coefficient at least */
@@ -1167 +1174 @@
              * end of search: have to reduce with pi
              */
-            z++;
-            if (z>10)
-            {
-                pNormalize(H.p);
-                z=0;
-            }
             if ((ei > H.ecart) && (strat->kNoether==NULL))
             {