Changeset bf8b65 in git for libpolys

Timestamp:

Apr 23, 2021, 11:01:05 AM (3 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '2a584933abf2a2d3082034c7586d38bb6de1a30a')

Children:

1f547ed4cc617ebefd435098637414a0fabd2084

Parents:

5fd24e69d9cdfcd1040ca93af529563f039efd2c

Message:

fix: n_IsUnit, n_GetUnit (Tst/Manual/simplify.tst)

File:

• libpolys/coeffs/numbers.cc (modified) (3 diffs)

libpolys/coeffs/numbers.cc

@@ -119 +119 @@
 }
 
-static BOOLEAN ndIsUnit(number a, const coeffs r)
+static BOOLEAN ndIsUnit_Ring(number a, const coeffs r)
 { return r->cfIsOne(a,r)|| r->cfIsMOne(a,r); }
-static number ndGetUnit(number a, const coeffs r)
+static BOOLEAN ndIsUnit_Field(number a, const coeffs r)
+{ return !r->cfIsZero(a,r); }
+static number ndGetUnit_Ring(number a, const coeffs r)
 { return r->cfInit(1,r); }
 #ifdef LDEBUG
@@ -407 +409 @@
     n->cfClearDenominators = ndClearDenominators;
 
-    n->cfIsUnit = ndIsUnit;
+    //n->cfIsUnit = ndIsUnit;
 #ifdef HAVE_RINGS
     n->cfDivComp = ndDivComp;
     n->cfDivBy = ndDivBy;
     n->cfExtGcd = ndExtGcd;
-    n->cfGetUnit = ndGetUnit;
+    //n->cfGetUnit = ndGetUnit;
 #endif
 
@@ -438 +440 @@
     if (n->cfExactDiv==NULL) n->cfExactDiv=n->cfDiv;
     if (n->cfSubringGcd==NULL) n->cfSubringGcd=n->cfGcd;
-
+    if (n->cfIsUnit==NULL)
+    {
+      if (n->is_field) n->cfIsUnit=ndIsUnit_Field;
+      else             n->cfIsUnit=ndIsUnit_Ring;
+    }
+    #ifdef HAVE_RING
+    if (n->cfGetUnit==NULL)
+    {
+      if (n->is_field) n->cfGetUnit=n->cfCopy;
+      else             n->cfGetUnit=ndGetUnit_Ring;
+    }
+    #endif
 
     if(n->cfWriteShort==NULL)