Changeset ce912c in git

Timestamp:

Jul 15, 2019, 5:12:46 PM (5 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '4a9821a93ffdc22a6696668bd4f6b8c9de3e6c5f')

Children:

dcf353c04b0c8c5945b92c2d852b51473aea48a0

Parents:

d96888fdc2a0491751aa5c1f77cf5a3759e219ae

Message:

fix: pp_DivideM

File:

• libpolys/polys/monomials/p_polys.cc (modified) (1 diff)

libpolys/polys/monomials/p_polys.cc

@@ -1616 +1616 @@
 {
   if (a==NULL) { return NULL; }
-
-  poly result=p_Copy(a,r);
-  a=result;
-  b=p_Head(b,r);
-  if(!p_IsConstant(b,r))
-  {
-    if (rIsLPRing(r))
-    {
-      WerrorS("not implemented for letterplace rings");
-      return NULL;
-    }
-    poly prev=NULL;
-    while (a!=NULL)
-    {
-      if (p_DivisibleBy(b,a,r))
-      {
-        p_ExpVectorSub(a,b,r);
-        prev=a;
-        pIter(a);
-      }
-      else
-      {
-        if (prev==NULL)
-        {
-          p_LmDelete(&result,r);
-          a=result;
-        }
-        else
-        {
-          p_LmDelete(&pNext(prev),r);
-          a=pNext(prev);
-        }
-      }
-    }
-  }
-  if (result!=NULL)
-  {
-    number inv=pGetCoeff(b);
-    //if ((!rField_is_Ring(r)) || n_IsUnit(inv,r->cf))
-    if (rField_is_Zp(r))
-    {
-      inv = n_Invers(inv,r->cf);
-      __p_Mult_nn(result,inv,r);
-    }
-    else
-    {
-      inv=n_Copy(inv,r->cf);
-      result = p_Div_nn(result,inv,r);
-      n_Delete(&inv, r->cf);
-    }
-  }
-  p_Delete(&b,r);
-  return result;
+  // TODO: better implementation without copying a,b
+  return p_DivideM(p_Copy(a,r),p_Head(b,r),r);
 }