Changeset d0731c9 in git for kernel

Timestamp:

Aug 18, 2022, 2:16:53 PM (20 months ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

658a2a6ece0eabe6c77c1b26617f3cfb4b48b269

Parents:

e2f3add89e519e0e28202da04bf023e70cebb0d9

Message:

fix: stdZ for euclidean rings: allow QuotRem

File:

• kernel/GBEngine/kstd2.cc (modified) (5 diffs)

kernel/GBEngine/kstd2.cc

@@ -147 +147 @@
     unsigned long not_sev     = ~L->sev;
     const unsigned long sevT0 = strat->sevT[0];
-    number orest;
+    number orest,rest,mult;
     if (L->p!=NULL)
     {
@@ -160 +160 @@
         if (p_LmShortDivisibleBy(T0p, sevT0, p, not_sev, r))
         {
-          if(n_DivBy(orest, pGetCoeff(T0p), r->cf))
+          if(n_DivBy(pGetCoeff(p), pGetCoeff(T0p), r->cf))
           {
             return 0;
           }
+          if (n_QuotRem!=ndQuotRem) /*euclidean ring*/
+          {
+            mult= n_QuotRem(pGetCoeff(p), pGetCoeff(T0p), &rest, r->cf);
+            if (!n_IsZero(mult, r->cf) && n_Greater(n_EucNorm(orest, r->cf), n_EucNorm(rest, r->cf), r->cf))
+            {
+              n_Delete(&mult,r->cf);
+              n_Delete(&rest,r->cf);
+              return 0;
+            }
+            n_Delete(&mult,r->cf);
+            n_Delete(&rest,r->cf);
+          }
         }
 #else
@@ -171 +183 @@
           {
             return 0;
+          }
+          if (n_QuotRem!=ndQuotRem) /*euclidean ring*/
+          {
+            mult= n_QuotRem(pGetCoeff(p), pGetCoeff(T0p), &rest, r->cf);
+            if (!n_IsZero(mult, r->cf) && n_Greater(n_EucNorm(orest, r->cf), n_EucNorm(rest, r->cf), r->cf))
+            {
+              n_Delete(&mult,r->cf);
+              n_Delete(&rest,r->cf);
+              return 0;
+            }
+            n_Delete(&mult,r->cf);
+            n_Delete(&rest,r->cf);
           }
         }
@@ -189 +213 @@
             return 0;
           }
+          if (n_QuotRem!=ndQuotRem) /*euclidean ring*/
+          {
+            mult= n_QuotRem(pGetCoeff(p), pGetCoeff(T0p), &rest, r->cf);
+            if (!n_IsZero(mult, r->cf) && n_Greater(n_EucNorm(orest, r->cf), n_EucNorm(rest, r->cf), r->cf))
+            {
+              n_Delete(&mult,r->cf);
+              n_Delete(&rest,r->cf);
+              return 0;
+            }
+            n_Delete(&mult,r->cf);
+            n_Delete(&rest,r->cf);
+          }
         }
 #else
@@ -196 +232 @@
           {
             return 0;
+          }
+          if (n_QuotRem!=ndQuotRem) /*euclidean ring*/
+          {
+            mult= n_QuotRem(pGetCoeff(p), pGetCoeff(T0p), &rest, r->cf);
+            if (!n_IsZero(mult, r->cf) && n_Greater(n_EucNorm(orest, r->cf), n_EucNorm(rest, r->cf), r->cf))
+            {
+              n_Delete(&mult,r->cf);
+              n_Delete(&rest,r->cf);
+              return 0;
+            }
+            n_Delete(&mult,r->cf);
+            n_Delete(&rest,r->cf);
           }
         }