Changeset d6b072c in git

Timestamp:

May 20, 1996, 3:39:48 PM (28 years ago)

Author:

Rüdiger Stobbe <stobbe@…>

Branches:

(u'spielwiese', 'e7cc1ebecb61be8b9ca6c18016352af89940b21a')

Children:

76470b9a30fae98fb8f716432d745cf299a95b33

Parents:

17fdd790965f3a15247d3eaa31fc2491357bdc2e

Message:

"sqrFree: Now the product of all factors found by sqrFree is equal to the
         parameter of sqrFree. The bug resulted from an incorrect handling
         of the leading coefficient of the argument of sqrFree.
"


git-svn-id: file:///usr/local/Singular/svn/trunk@10 2c84dea3-7e68-4137-9b89-c4e89433aadc

File:

• factory/fac_sqrfree.cc (modified) (4 diffs)

factory/fac_sqrfree.cc

@@ -1 +1 @@
 // emacs edit mode for this file is -*- C++ -*-
-// $Id: fac_sqrfree.cc,v 1.0 1996-05-17 10:59:45 stobbe Exp $
+// $Id: fac_sqrfree.cc,v 1.1 1996-05-20 13:39:48 stobbe Exp $
 
 #include "assert.h"
@@ -8 +8 @@
 /*
 $Log: not supported by cvs2svn $
+// Revision 1.0  1996/05/17  10:59:45  stobbe
+// Initial revision
+//
 */
 
@@ -20 +23 @@
 {
     CanonicalForm t0 = f, t, v, w, h;
+    CanonicalForm leadcf = t0.lc();
     Variable x = f.mvar();
     CFFList F;
     int p = getCharacteristic();
     int k, e = 1;
+
+    if ( ! leadcf.isOne() )
+        t0 /= leadcf;
 
     divexp = p;
@@ -41 +48 @@
             t /= v;
             if ( h.degree(x) > 0 )
-                F.append( CFFactor( h, e*k ) );
+                F.append( CFFactor( h/h.lc(), e*k ) );
         }
         t0 = apply( t, divexpfunc );
         e = p * e;
+    }
+    if ( ! leadcf.isOne() ) {
+        if ( F.getFirst().exp() == 1 ) {
+            leadcf = F.getFirst().factor() * leadcf;
+            F.removeFirst();
+        }
+        F.insert( CFFactor( leadcf, 1 ) );
     }
     return F;