Changeset dbb268 in git

Timestamp:

Nov 3, 2017, 11:57:29 AM (6 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

cfaf16d7ec0e634d40eb72124b2b9216565e3177

Parents:

2de0cebc393fed2c7b5d269cc711aa13cdcc73a4

Message:

fix: memory leaks in ntGcd and ntDiv

File:

• libpolys/polys/ext_fields/transext.cc (modified) (6 diffs)

libpolys/polys/ext_fields/transext.cc

@@ -1147 +1147 @@
     DEN(result) = f;
   }
+  else
+  {
+    p_Delete(&f, ntRing);
+  }
   COM(result) = COM(fa) + COM(fb) + MULT_COMPLEXITY;
 //  definiteGcdCancellation((number)result, cf,FALSE);
@@ -1726 +1730 @@
   fraction fb = (fraction)b;
 
-  poly pa = p_Copy(NUM(fa), ntRing);
-  poly pb = p_Copy(NUM(fb), ntRing);
 
   poly pGcd;
   if (nCoeff_is_Q(ntCoeffs))
   {
+    poly pa = NUM(fa);
+    poly pb = NUM(fb);
     if (p_IsConstant(pa,ntRing) && p_IsConstant(pb,ntRing))
     {
-      pGcd = pa;
+      pGcd = p_Copy(pa,ntRing);
       p_SetCoeff (pGcd, n_SubringGcd (pGetCoeff(pGcd), pGetCoeff(pb), ntCoeffs), ntRing);
     }
@@ -1741 +1745 @@
       number contentpa, contentpb, tmp;
 
-      contentpb= p_GetCoeff(pb, ntRing);
+      contentpb= n_Copy(p_GetCoeff(pb, ntRing),ntCoeffs);
       pIter(pb);
       while (pb != NULL)
@@ -1751 +1755 @@
       }
 
-      contentpa= p_GetCoeff(pa, ntRing);
+      contentpa= n_Copy(p_GetCoeff(pa, ntRing),ntCoeffs);
       pIter(pa);
       while (pa != NULL)
@@ -1765 +1769 @@
       n_Delete(&contentpb, ntCoeffs);
       contentpa= tmp;
-      p_Delete(&pb, ntRing);
-      p_Delete(&pa, ntRing);
 
       /* singclap_gcd destroys its arguments; we hence need copies: */
@@ -1775 +1777 @@
   }
   else
-    pGcd = singclap_gcd(pa, pb, cf->extRing);
+    pGcd = singclap_gcd(p_Copy(NUM(fa),ntRing), p_Copy(NUM(fb),ntRing), ntRing);
   /* Note that, over Q, singclap_gcd will remove the denominators in all
      rational coefficients of pa and pb, before starting to compute