Changeset dc42daf in git for libpolys/polys/ext_fields/algext.cc

Timestamp:

Feb 21, 2013, 7:13:50 PM (10 years ago)

Author:

Claus Fieker <fieker@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'a800fe4b3e9d37a38c5a10cc0ae9dfa0c15a4ee6')

Children:

5693d74c7e74fb28bc22148699aebb6524ded48c

Parents:

892dd80edda39f846824ca997ef834ad6d19f748

git-author:

Claus Fieker <fieker@erbsenstein.(none)>2013-02-21 19:13:50+01:00

git-committer:

Claus Fieker <fieker@erbsenstein.(none)>2013-02-22 16:40:29+01:00

Message:

an attempt to introduce better normalization for polynomials over number fields. Seems to work well in selected examples...

File:

• libpolys/polys/ext_fields/algext.cc (modified) (6 diffs)

libpolys/polys/ext_fields/algext.cc

@@ -220 +220 @@
 }
 
+
 /* assumes that p and q are univariate polynomials in r,
    mentioning the same variable;
@@ -505 +506 @@
   poly aTimesB = p_Mult_q(p_Copy((poly)a, naRing),
                           p_Copy((poly)b, naRing), naRing);
+  definiteReduce(aTimesB, naMinpoly, cf);
   p_Normalize(aTimesB,naRing);
-  definiteReduce(aTimesB, naMinpoly, cf);
   return (number)aTimesB;
 }
@@ -520 +521 @@
     poly aDivB = p_Mult_q(p_Copy((poly)a, naRing), bInverse, naRing);
     definiteReduce(aDivB, naMinpoly, cf);
+    p_Normalize(aDivB,naRing);
     return (number)aDivB;
   }
@@ -682 +684 @@
     pIter(bb);
   }
+  return h;
 }
 number naLcmContent(number a, number b, const coeffs cf)
 {
   if (nCoeff_is_Zp(naRing->cf)) return naCopy(a,cf);
-  else return ndGcd(a,b,cf);
-  #if 0
+#if 0
+  else {
+    number g = ndGcd(a, b, cf);
+    return g;
+  }
+#else
   {
     a=(number)p_Copy((poly)a,naRing);
     number t=napLcm(b,cf);
-    if(!naIsOne(t,cf))
+    if(!n_IsOne(t,naRing->cf))
     {
       number bt, rr;
@@ -710 +717 @@
     return (number) a;
   }
-  #endif
+#endif
 }
 
@@ -1195 +1202 @@
 
   }
+
 
   // part3: all coeffs = all coeffs / cand