Changeset dccb85 in git

Timestamp:

Feb 3, 2015, 9:40:17 AM (9 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '8e0ad00ce244dfd0756200662572aef8402f13d5')

Children:

1d0b91fbec50d1a0fc884eb1fe44cf48dfd0ff8e

Parents:

bd3bac8ebfab4a67210d850dc35a296d9a4a9afa

Message:

comment: n_isUnit is not needed in cancelunit/cancelunit1

File:

• kernel/GBEngine/kutil.cc (modified) (2 diffs)

kernel/GBEngine/kutil.cc

@@ -339 +339 @@
 #endif
 
-#ifdef HAVE_RINGS  // needs cleanup
+#ifdef HAVE_RINGS
   // Leading coef have to be a unit
+  // example 2x+4x2 should be simplified to 2x*(1+2x)
+  // and 2 is not a unit in Z
   //if ( !(n_IsUnit(pGetCoeff(p), r->cf)) ) return;
 #endif
@@ -6546 +6548 @@
   if (!pIsVector((*p).p) && ((*p).ecart != 0))
   {
-#ifdef HAVE_RINGS // needs cleanup
-    // Leading coef have to be a unit
-    if ( !(n_IsUnit(pGetCoeff((*p).p), currRing->cf)) ) return;
+#ifdef HAVE_RINGS
+    // Leading coef have to be a unit: no
+    // example 2x+4x2 should be simplified to 2x*(1+2x)
+    // and 2 is not a unit in Z
+    //if ( !(n_IsUnit(pGetCoeff((*p).p), currRing->cf)) ) return;
 #endif
     k = 0;