Changeset de88371 in git for libpolys/coeffs/coeffs.h

Timestamp:

Jul 18, 2012, 3:28:22 PM (11 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'c987db42cd2ec943b97ac5746c99892ceddf909c')

Children:

91ecf187772d8c5893550eabd5abde87d2f29b9c

Parents:

975db1808b2b0917d858a9096710abc55c256aec

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-07-18 15:28:22+02:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-07-18 15:41:07+02:00

Message:

Added stubs for putting the actual code (TODO!), where required (i.e. described) by Hans

chg: descriptions for the output number (n_ClearContent & n_ClearDenominators)
chg: publicly available default implementations ndClearContent & ndClearDenominators for fallback calls

File:

• libpolys/coeffs/coeffs.h (modified) (2 diffs)

libpolys/coeffs/coeffs.h

@@ -813 +813 @@
 /// Computes the content and (inplace) divides it out on a collection
 /// of numbers
-/// NOTE/TODO: see the description by Hans
-/// TODO: what exactly is c?
+/// number @em c is the content (i.e. the GCD of all the coeffs, which
+/// we divide out inplace)
+/// NOTE: it assumes all coefficient numbers to be integer!!!
+/// NOTE/TODO: see also the description by Hans
+/// TODO: rename into n_ClearIntegerContent
 static inline void n_ClearContent(ICoeffsEnumerator& numberCollectionEnumerator, number& c, const coeffs r)
 {
@@ -822 +825 @@
 
 /// (inplace) Clears denominators on a collection of numbers
-/// NOTE/TODO: see the description by Hans
-/// TODO: what exactly is d?
+/// number @em d is the LCM of all the coefficient denominators (i.e. the number
+/// with which all the number coeffs. were multiplied)
+/// NOTE/TODO: see also the description by Hans
 static inline void n_ClearDenominators(ICoeffsEnumerator& numberCollectionEnumerator, number& d, const coeffs r)
 {