Changeset e0047d in git for factory/facFqFactorize.cc

Timestamp:

Aug 30, 2012, 1:50:27 PM (12 years ago)

Author:

Martin Lee <martinlee84@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

bf4c6ef72e2d8a1ee598aebcb4ca4ca73a2f2efa

Parents:

c5230d1466985a6275693ea38409e2f5641a6e6e

git-author:

Martin Lee <martinlee84@web.de>2012-08-30 13:50:27+02:00

git-committer:

Martin Lee <martinlee84@web.de>2012-09-05 15:00:01+02:00

Message:

fix: minor bug in evaluationWRTDifferentSecondVar

File:

• factory/facFqFactorize.cc (modified) (3 diffs)

factory/facFqFactorize.cc

@@ -1744 +1744 @@
   CFListIterator iter;
   bool preserveDegree= true;
-  int j;
+  Variable x= Variable (1);
+  int j, degAi, degA1= degree (A,1);
   for (int i= A.level(); i > 2; i--)
   {
@@ -1751 +1752 @@
     iter= evaluation;
     preserveDegree= true;
+    degAi= degree (A,i);
     for (j= A.level(); j > 1; j--, iter++)
     {
@@ -1759 +1761 @@
         tmp= tmp (iter.getItem(), j);
         tmp2.insert (tmp);
-        if ((degree (tmp, i) != degree (A, i)) ||
-            (degree (tmp, 1) != degree (A, 1)))
+        if ((degree (tmp, i) != degAi) ||
+            (degree (tmp, 1) != degA1))
         {
           preserveDegree= false;
           break;
         }
-        if (!content(tmp).inCoeffDomain() || !content(tmp,1).inCoeffDomain())
-        {
-          preserveDegree= false;
-          break;
-        }
-      }
-    }
+      }
+    }
+    if (!content(tmp,1).inCoeffDomain())
+      preserveDegree= false;
+    if (!(gcd (deriv (tmp,x), tmp)).inCoeffDomain())
+      preserveDegree= false;
     if (preserveDegree)
       Aeval [i - 3]= tmp2;