Changeset e39ca0 in git

Timestamp:

Nov 28, 2016, 3:27:11 PM (7 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'a657104b677b4c461d018cbf3204d72d34ad66a9')

Children:

adb7b747e50418d86748b27ced0b13733493bee6

Parents:

c665c39ebd2c9d0fa178ec7004ad58d5c91333ec

Message:

fix: memory leak in minor(m,k,I)

File:

• kernel/linear_algebra/MinorInterface.cc (modified) (1 diff)

kernel/linear_algebra/MinorInterface.cc

@@ -268 +268 @@
   /* copy all polynomials and reduce them w.r.t. iSB
      (if iSB is present, i.e., not the NULL pointer) */
-  for (int i = 0; i < length; i++)
-  {
-    nfPolyMatrix[i] = pCopy(myPolyMatrix[i]);
-    if (iSB != 0) nfPolyMatrix[i] = kNF(iSB, currRing->qideal,
-                                        nfPolyMatrix[i]);
+  if (iSB != NULL)
+  {
+    for (int i = 0; i < length; i++)
+    {
+      nfPolyMatrix[i] = kNF(iSB, currRing->qideal,myPolyMatrix[i]);
+    }
+  }
+  else
+  {
+    for (int i = 0; i < length; i++)
+    {
+      nfPolyMatrix[i] = pCopy(myPolyMatrix[i]);
+    }
   }