Changeset e8c1286 in git

Timestamp:

Apr 24, 2019, 7:31:54 PM (4 years ago)

Author:

Karim Abou Zeid <karim23697@…>

Branches:

(u'spielwiese', '8e0ad00ce244dfd0756200662572aef8402f13d5')

Children:

220dc1a0cfcef407839d7120bc6f0962c40ae9c3

Parents:

4ed84fc76dd9f28f462bf81c365f44aba3caccf6

Message:

Fix lpGkDim

File:

• Singular/dyn_modules/freealgebra/freealgebra.cc (modified) (5 diffs)

Singular/dyn_modules/freealgebra/freealgebra.cc

@@ -249 +249 @@
 
 // -1 is infinity
-static int graphGrowth(intvec G)
+static int graphGrowth(const intvec G)
 {
   // init
@@ -274 +274 @@
 
 // -1 is infinity, -2 is error
-static int id_LPGkDim(ideal G)
+static int id_LPGkDim(const ideal _G)
 {
   if (rField_is_Ring(currRing)) {
@@ -281 +281 @@
   }
 
-  idSkipZeroes(G); // remove zeros
-  for (int i=IDELEMS(G)-1;i>=0; i--)
-  {
-    G->m[i]->next = NULL; // G = LM(G)
-    if (pGetComp(G->m[i]) != 0)
+  for (int i=IDELEMS(_G)-1;i>=0; i--)
+  {
+    if (pGetComp(_G->m[i]) != 0)
     {
       WerrorS("GK-Dim not implemented for modules");
@@ -291 +289 @@
     }
   }
+
+  ideal G = id_Head(_G, currRing); // G = LM(G) (and copy)
+  idSkipZeroes(G); // remove zeros
   id_DelLmEquals(G, currRing); // remove duplicates
 
@@ -330 +331 @@
   {
     assumeStdFlag(h);
-    ideal G=(ideal)h->Data();
+    ideal G = (ideal) h->Data();
     res->rtyp = INT_CMD;
     res->data = (void*)(long) id_LPGkDim(G);