Changeset eedce96 in git

Timestamp:

Oct 25, 2022, 1:41:25 PM (5 months ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'f875bbaccd0831e36aaed09ff6adeb3eb45aeb94')

Children:

6494278d27d1617e138006df909851e815ccfe02

Parents:

f0c08683e2be02e991de433ab791ef32c361b2d4

Message:

fix: ring R1=R2,.. with R2 a qring

Files:

• Singular/ipshell.cc (modified) (2 diffs)
• Tst/Short/bug_tr873.res.gz.uu (modified) (1 diff)
• Tst/Short/bug_tr873.stat (modified) (1 diff)
• Tst/Short/bug_tr873.tst (modified) (2 diffs)

Singular/ipshell.cc

@@ -2893 +2893 @@
           TransExtInfo extParam;
           extParam.r = extRing;
-          assume( extRing->qideal == NULL );
 
           R->cf = nInitChar(n_transExt, &extParam);
@@ -5890 +5889 @@
   else if ((pn->Typ()==RING_CMD) && (P == 1))
   {
-    TransExtInfo extParam;
-    extParam.r = (ring)pn->Data();
-    extParam.r->ref++;
-    cf = nInitChar(n_transExt, &extParam);
-  }
-  //else if ((pn->Typ()==QRING_CMD) && (P == 1)) // same for qrings - which should be fields!?
-  //{
-  //  AlgExtInfo extParam;
-  //  extParam.r = (ring)pn->Data();
-
-  //  cf = nInitChar(n_algExt, &extParam);   // Q[a]/<minideal>
-  //}
+    ring r=(ring)pn->Data();
+    if (r->qideal==NULL)
+    {
+      TransExtInfo extParam;
+      extParam.r = r;
+      extParam.r->ref++;
+      cf = nInitChar(n_transExt, &extParam); // R(a)
+    }
+    else if (IDELEMS(r->qideal)==1)
+    {
+      AlgExtInfo extParam;
+      extParam.r=r;
+      extParam.r->ref++;
+      cf = nInitChar(n_algExt, &extParam);   // R[a]/<minideal>
+    }
+    else
+    {
+      WerrorS("algebraic extension ring must have one minpoly");
+      goto rInitError;
+    }
+  }
   else
   {

Tst/Short/bug_tr873.res.gz.uu

@@ -1 @@
-begin 644 bug_tr873.res.gz
-M'XL("./`@F`"`V)U9U]T<C@W,RYR97,`U9'-BL(P%(7W>8J#S"*Q)1JU,T*F
-M68@(A<&%NAN&TC_E@G2&-N)"YMTG'6J+Z`NXRLWY;I)S<[:[9;0&H`P^H@4&
-MMK;R2.E`LVU+)@9.C*DDRX5FS0ICD)X.L:WF;U-9%F=9V\1V)Z8&73V3V']7
-MG$H+"I6F]T"3YXF.!Q*7;O,J45%YP`HAQCY/_%3X^4]O9=[RC>,KGV<W5(TE
-M*"^2(R*'LUZ?2-0VYY'H)>?JE\6?ZBO,V&B$X1!5D1=[-]O_Z_R1"W'?N6D[
-@;_R(Y[WX^CU!'Z!RF33Q-P&?:JZ$?F%_S_92J#0"````
+begin 640 bug_tr873.res.gz
+M'XL("&/'5V,"`V)U9U]T<C@W,RYR97,`[5--:\,P#+WG5XBR@]T:-W:7-I#%
+MAS$*@3%HNEL9(5\MAI!MB<L.8_]]SI;8A'3[!3U)?D]^DFQI__P0/0$`$_`8
+MW<-,M8I6,IL%SKYGN``-)K*6"N'`Z2P(`=GYE*C&WZQH77[05J7*W%@),/XM
+MA4;6)]BQT"625&]6V!/P_LOQ4%IX+>#XVB!9*Y`A"^2=%\C%`AM^0^'3'/Q>
+M?@LAN`2E),.DL#F8V_.QYK<$Y6.64Y!%F580:3JWN"ZZ506*L(76@U"GM.,3
+M*?^R%'<G4EQG-;[.].4D!_82YH-9+F$^AZ8LRJ-^ZY_>T*4>\30R[B-'W>(_
+GA6,3/VX*7TOYKY3A[SP[YER/1[<DW1J<6\1P<.-\`Q9^>?!:`P``
 `
 end

Tst/Short/bug_tr873.stat

@@ -1 @@
-1 >> tst_memory_0 :: 1619181795:4202, 64 bit:4.2.0:x86_64-Linux:terra:87912
-1 >> tst_memory_1 :: 1619181795:4202, 64 bit:4.2.0:x86_64-Linux:terra:2150192
-1 >> tst_memory_2 :: 1619181795:4202, 64 bit:4.2.0:x86_64-Linux:terra:2191296
-1 >> tst_timer_1 :: 1619181795:4202, 64 bit:4.2.0:x86_64-Linux:terra:3
+1 >> tst_memory_0 :: 1666697059:4312, 64 bit:4.3.1:x86_64-Linux:nepomuck:87608
+1 >> tst_memory_1 :: 1666697059:4312, 64 bit:4.3.1:x86_64-Linux:nepomuck:2150192
+1 >> tst_memory_2 :: 1666697059:4312, 64 bit:4.3.1:x86_64-Linux:nepomuck:2191296
+1 >> tst_timer_1 :: 1666697059:4312, 64 bit:4.3.1:x86_64-Linux:nepomuck:2

Tst/Short/bug_tr873.tst

@@ -2 +2 @@
 tst_init();
 
+ring Q1=0,i,lp;
+qring Q2=i;
 for(int i=1;i<5;i++)
 {
@@ -8 +10 @@
 ideal I = c;
 std(I);
+ring RR = Q2,(c),dp;
+ideal I = c;
+std(I);
+
 }