Changeset f22f22a in git

Timestamp:

Jan 14, 2017, 5:59:00 PM (7 years ago)

Author:

Volker Braun <vbraun.name@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

e85feda0c40361dfe1754b7c0fa791e33c600e71

Parents:

d22092faa534a77b8f85e33d87fee0070e584166

git-author:

Volker Braun <vbraun.name@gmail.com>2017-01-14 17:59:00+01:00

git-committer:

Volker Braun <vbraun.name@gmail.com>2017-01-14 17:59:38+01:00

Message:

fix: Increase library filename buffer length

Increase the buffer size from 128 to 1024 chars. E.g. Conda and Sage
intentionally build binaries with long (>100 chars) parent directories
to truncate them when installing the binaries. This caused random
segfaults, see https://trac.sagemath.org/ticket/22175

Location:

Singular

Files:

• fehelp.cc (modified) (1 diff)
• iparith.cc (modified) (2 diffs)
• iplib.cc (modified) (3 diffs)
• libparse.cc (modified) (1 diff)
• libparse.ll (modified) (1 diff)

Singular/fehelp.cc

@@ -703 +703 @@
   }
 
-  char libnamebuf[128];
+  char libnamebuf[1024];
   FILE *fp=NULL;
   // first, search for library of that name

Singular/iparith.cc

@@ -5117 +5117 @@
 BOOLEAN jjLOAD(const char *s, BOOLEAN autoexport)
 {
-  char libnamebuf[256];
+  char libnamebuf[1024];
   lib_types LT = type_of_LIB(s, libnamebuf);
 
@@ -5152 +5152 @@
         currPack=IDPACKAGE(pl);
         IDPACKAGE(pl)->loaded=TRUE;
-        char libnamebuf[256];
+        char libnamebuf[1024];
         FILE * fp = feFopen( s, "r", libnamebuf, TRUE );
         BOOLEAN bo=iiLoadLIB(fp, libnamebuf, s, pl, autoexport, TRUE);

Singular/iplib.cc

@@ -657 +657 @@
 {
   BOOLEAN LoadResult = TRUE;
-  char libnamebuf[128];
+  char libnamebuf[1024];
   char *libname = (char *)omAlloc(strlen(id)+5);
   const char *suffix[] = { "", ".lib", ".so", ".sl", NULL };
@@ -673 +673 @@
       char *s=omStrDup(libname);
       #ifdef HAVE_DYNAMIC_LOADING
-      char libnamebuf[256];
+      char libnamebuf[1024];
       #endif
 
@@ -718 +718 @@
 BOOLEAN iiLibCmd( char *newlib, BOOLEAN autoexport, BOOLEAN tellerror, BOOLEAN force )
 {
-  char libnamebuf[128];
+  char libnamebuf[1024];
   // procinfov pi;
   // idhdl h;

Singular/libparse.cc

@@ -1094 +1094 @@
 lib_cmds last_cmd = LP_NONE;
 
-char libnamebuf[128];
+char libnamebuf[1024];
 char *text_buffer=NULL;
 long string_start;

Singular/libparse.ll

@@ -45 +45 @@
 lib_cmds last_cmd = LP_NONE;
 
-char libnamebuf[128];
+char libnamebuf[1024];
 char *text_buffer=NULL;
 long string_start;