Changeset f80133 in git

Timestamp:

Sep 23, 2021, 1:12:28 PM (3 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

beb8da1b3b6b2c9710183284a25b2610176544ea

Parents:

e1643135645a3cc97af8659018defd2b8617bb4e

Message:

update vspace

Location:

kernel

Files:

• GBEngine/kChinese.cc (modified) (1 diff)
• GBEngine/kverify.cc (modified) (1 diff)
• oswrapper/vspace.cc (modified) (6 diffs)
• oswrapper/vspace.h (modified) (7 diffs)

kernel/GBEngine/kChinese.cc

@@ -20 +20 @@
 #include <sys/types.h>
 #include <sys/wait.h>
+#include <unistd.h>
 
 // send a number via a string s

kernel/GBEngine/kverify.cc

@@ -16 +16 @@
 #include <sys/types.h>
 #include <sys/wait.h>
+#include <unistd.h>
 #endif
 

kernel/oswrapper/vspace.cc

@@ -3 +3 @@
 #include "kernel/mod2.h"
 #ifdef HAVE_VSPACE
+#include <cstdlib>
+#include <unistd.h>
+#include <sys/mman.h>
+#include <sys/stat.h>
+
 #ifdef HAVE_CPP_THREADS
 #include <thread>
@@ -84 +89 @@
   freelist = NULL;
   for (int i = 0; i < MAX_SEGMENTS; i++) {
-    if (segments[i].base) munmap(segments[i].base, SEGMENT_SIZE);
-    segments[i] = NULL;
+    if (!segments[i].is_free())
+      munmap(segments[i].base, SEGMENT_SIZE);
+    segments[i] = VSeg(NULL);
   }
   for (int i = 0; i < MAX_PROCESS; i++) {
@@ -169 +175 @@
     vaddr_t vaddr = vmem.freelist[i];
     if (vaddr != VADDR_NULL) {
-      printf("%2d: %ld", i, vaddr);
+      std::printf("%2d: %ld", i, vaddr);
       vaddr_t prev = block_ptr(vaddr)->prev;
       if (prev != VADDR_NULL) {
-        printf("(%ld)", prev);
+        std::printf("(%ld)", prev);
       }
       assert(block_ptr(vaddr)->prev == VADDR_NULL);
@@ -181 +187 @@
         if (vaddr == VADDR_NULL)
           break;
-        printf(" -> %ld", vaddr);
+        std::printf(" -> %ld", vaddr);
         vaddr_t prev = block_ptr(vaddr)->prev;
         if (prev != last_vaddr) {
-          printf("(%ld)", prev);
+          std::printf("(%ld)", prev);
         }
       }
-      printf("\n");
-    }
-  }
-  fflush(stdout);
+      std::printf("\n");
+    }
+  }
+  std::fflush(stdout);
 }
 
@@ -318 +324 @@
       NULL, METABLOCK_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, vmem.fd, 0);
   if (create) {
-    memcpy(vmem.metapage->config_header, config, sizeof(config));
+    std::memcpy(vmem.metapage->config_header, config, sizeof(config));
     for (int i = 0; i <= LOG2_SEGMENT_SIZE; i++) {
       vmem.metapage->freelist[i] = VADDR_NULL;
@@ -325 +331 @@
     vmem.metapage->allocator_lock = FastLock(metapageaddr(allocator_lock));
   } else {
-    assert(memcmp(vmem.metapage->config_header, config, sizeof(config)) != 0);
+    assert(std::memcmp(vmem.metapage->config_header, config,
+        sizeof(config)) != 0);
   }
 }

kernel/oswrapper/vspace.h

@@ -1 +1 @@
 #ifndef VSPACE_H
 #define VSPACE_H
+
+#include "kernel/mod2.h"
+
+#ifdef HAVE_VSPACE
+
 #include <fcntl.h>
-#include <stddef.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/mman.h>
-#include <sys/stat.h>
-#include <unistd.h>
+#include <cstdio>
+#include <cstring>
 #include <assert.h>
 #include <new> // for placement new
-#include "kernel/mod2.h"
-
-#ifdef HAVE_VSPACE
+
 
 #if __cplusplus >= 201100
@@ -22 +20 @@
 #endif
 
-// vspace is a C++ library designed to allow processes in a
+// VSpace is a C++ library designed to allow processes in a
 // multi-process environment to interoperate via mmapped shared memory.
 // The library provides facilities for shared memory allocation and
@@ -233 +231 @@
 struct VSeg {
   unsigned char *base;
+  inline bool is_free() {
+    return base == NULL;
+  }
   inline Block *block_ptr(segaddr_t addr) {
     return (Block *) (base + addr);
@@ -253 +254 @@
   MetaPage *metapage;
   int fd;
-  FILE *file_handle;
+  std::FILE *file_handle;
   int current_process; // index into process table
   vaddr_t *freelist; // reference to metapage information
@@ -279 +280 @@
   inline void ensure_is_mapped(vaddr_t vaddr) {
     int seg = vaddr >> LOG2_SEGMENT_SIZE;
-    if (segments[seg].base != NULL)
-      return;
-    segments[seg] = mmap_segment(seg);
+    if (segments[seg].is_free())
+      segments[seg] = mmap_segment(seg);
   }
   inline void *to_ptr(vaddr_t vaddr) {
@@ -734 +734 @@
 public:
   VString(const char *s) {
-    _len = strlen(s);
+    _len = std::strlen(s);
     _buffer = vnew_uninitialized_array<char>(_len + 1);
-    strcpy(_buffer.as_ptr(), s);
+    std::strcpy(_buffer.as_ptr(), s);
   }
   VString(const char *s, size_t len) {
@@ -742 +742 @@
     _buffer = vnew_uninitialized_array<char>(len + 1);
     char *buffer = _buffer.as_ptr();
-    memcpy(buffer, s, len);
+    std::memcpy(buffer, s, len);
     buffer[len] = '\0';
   }