Changeset fd60be in git for libpolys/polys/ext_fields/transext.cc

Timestamp:

Feb 19, 2013, 8:24:02 PM (10 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '0d6b7fcd9813a1ca1ed4220cfa2b104b97a0a003')

Children:

3693cf538753b44f4862e8f7dc384771128b32d0

Parents:

c444f4bb94b31371e1eaab7e2df8f87c1d4f068d

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2013-02-19 20:24:02+01:00

git-committer:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2013-02-19 21:22:07+01:00

Message:

fix: ntGreater (Short/bug_tr329)

File:

• libpolys/polys/ext_fields/transext.cc (modified) (3 diffs)

libpolys/polys/ext_fields/transext.cc

@@ -609 +609 @@
   ntTest(b);
   number aNumCoeff = NULL; int aNumDeg = -1;
+  number aDenCoeff = NULL; int aDenDeg = -1;
   number bNumCoeff = NULL; int bNumDeg = -1;
+  number bDenCoeff = NULL; int bDenDeg = -1;
   if (!IS0(a))
   {
@@ -615 +617 @@
     aNumDeg = p_Totaldegree(NUM(fa), ntRing);
     aNumCoeff = p_GetCoeff(NUM(fa), ntRing);
+    if (DEN(fa)!=NULL)
+    {
+      aDenDeg = p_Totaldegree(DEN(fa), ntRing);
+      aDenCoeff=p_GetCoeff(DEN(fa),ntRing);
+    }
   }
   else return !(ntGreaterZero (b,cf));
@@ -622 +629 @@
     bNumDeg = p_Totaldegree(NUM(fb), ntRing);
     bNumCoeff = p_GetCoeff(NUM(fb), ntRing);
+    if (DEN(fb)!=NULL)
+    {
+      bDenDeg = p_Totaldegree(DEN(fb), ntRing);
+      bDenCoeff=p_GetCoeff(DEN(fb),ntRing);
+    }
   }
   else return ntGreaterZero(a,cf);
-  if (aNumDeg > bNumDeg) return TRUE;
-  if (aNumDeg < bNumDeg) return FALSE;
-  return n_Greater(aNumCoeff, bNumCoeff, ntCoeffs);
+  if (aNumDeg-aDenDeg > bNumDeg-bDenDeg) return TRUE;
+  if (aNumDeg-aDenDeg < bNumDeg-bDenDeg) return FALSE;
+  number aa;
+  number bb;
+  if (bDenCoeff==NULL) aa=n_Copy(aNumCoeff,ntRing->cf);
+  else                 aa=n_Mult(aNumCoeff,bDenCoeff,ntRing->cf);
+  if (aDenCoeff==NULL) bb=n_Copy(bNumCoeff,ntRing->cf);
+  else                 bb=n_Mult(bNumCoeff,aDenCoeff,ntRing->cf);
+  BOOLEAN rr= n_Greater(aa, bb, ntCoeffs);
+  n_Delete(&aa,ntRing->cf);
+  n_Delete(&bb,ntRing->cf);
+  return rr;
 }