omalloc/omallocClass.h is not installed but included from several headers

[lorenz@…]

The header omalloc/omallocClass.h is not installed by make install, but included in several headers:

include/factory/factory.h:#include <omalloc/omallocClass.h>
include/singular/Singular/attrib.h:#include <omalloc/omallocClass.h>
include/singular/kernel/GBEngine/kutil.h:#include <omalloc/omallocClass.h>
include/singular/kernel/GBEngine/tgbgauss.h:#include <omalloc/omallocClass.h>

There is a guard around the include in factory.h:

#ifdef HAVE_OMALLOC
#include <omalloc/omallocClass.h>
#endif

but HAVE_OMALLOC is set anyway (in include/factory/factoryconf.h).

The chain of the includes is:

In file included from /polymake/vcs/jenkins/jobs/singular/jobs/libsingular/prefix/include/singular/coeffs/coeffs.h:19:0,                
                 from /polymake/vcs/jenkins/jobs/singular/jobs/libsingular/prefix/include/singular/polys/monomials/ring.h:13,           
                 from /polymake/vcs/jenkins/jobs/singular/jobs/libsingular/prefix/include/singular/kernel/polys.h:15,
                 from /polymake/vcs/jenkins/jobs/singular/jobs/libsingular/prefix/include/singular/kernel/structs.h:23,
                 from /polymake/vcs/jenkins/jobs/singular/jobs/libsingular/prefix/include/singular/Singular/libsingular.h:7,            
                 from /tmp/polymake_9539_configure.cc:1:
/polymake/vcs/jenkins/jobs/singular/jobs/libsingular/prefix/include/factory/factory.h:29:34: fatal error: omalloc/omallocClass.h: No such file or directory
 #include <omalloc/omallocClass.h>
                                  ^
compilation terminated.

PS: This is a fresh installation for our jenkins tests and the installation directory is wiped every time.

[hannes]

Thanks, omalloc/omallalcClass.h will now be installed.

And, no, the guard for omalloc (in factory) is important: one can build factory without omalloc (and some people do).