Changeset 65148c4 in git for factory/facFqBivar.h

Timestamp:

Feb 18, 2013, 5:54:37 PM (11 years ago)

Author:

Oleksandr Motsak <malex984@…>

Branches:

(u'fieker-DuVal', '117eb8c30fc9e991c4decca4832b1d19036c4c65')(u'spielwiese', 'b4f17ed1d25f93d46dbe29e4b499baecc2fd51bb')

Children:

77ed18101c07cdbb767d8703e5ea1d0f7c8b05f6

Parents:

71a4d7b8fea297969227779896a8ec8fc63aaedaa1da6f6fa3cfce502fec23270a8a572c1290577d

Message:

Merge pull request #265 from mohamed-barakat/spielwiese

clang fixes

File:

• factory/facFqBivar.h (modified) (5 diffs)

factory/facFqBivar.h

@@ -49 +49 @@
             );
 
-/// factorize a squarefree bivariate polynomial over \f$ F_{p} \f$.
-///
-/// @return @a FpBiSqrfFactorize returns a list of monic factors, the first
-///         element is the leading coefficient.
-/// @sa FqBiSqrfFactorize(), GFBiSqrfFactorize()
-inline
-CFList FpBiSqrfFactorize (const CanonicalForm & G ///< [in] a bivariate poly
-                         )
+inline CFList
+biSqrfFactorizeHelper (const CanonicalForm& G, ExtensionInfo& info)
 {
-  ExtensionInfo info= ExtensionInfo (false);
   CFMap N;
   CanonicalForm F= compress (G, N);
@@ -65 +58 @@
   F /= (contentX*contentY);
   CFFList contentXFactors, contentYFactors;
-  contentXFactors= factorize (contentX);
-  contentYFactors= factorize (contentY);
+  if (info.getAlpha().level() != 1)
+  {
+    contentXFactors= factorize (contentX, info.getAlpha());
+    contentYFactors= factorize (contentY, info.getAlpha());
+  }
+  else if (info.getAlpha().level() == 1 && info.getGFDegree() == 1)
+  {
+    contentXFactors= factorize (contentX);
+    contentYFactors= factorize (contentY);
+  }
+  else if (info.getAlpha().level() == 1 && info.getGFDegree() != 1)
+  {
+    CFList bufContentX, bufContentY;
+    bufContentX= biFactorize (contentX, info);
+    bufContentY= biFactorize (contentY, info);
+    for (CFListIterator iter= bufContentX; iter.hasItem(); iter++)
+      contentXFactors.append (CFFactor (iter.getItem(), 1));
+    for (CFListIterator iter= bufContentY; iter.hasItem(); iter++)
+      contentYFactors.append (CFFactor (iter.getItem(), 1));
+  }
+
   if (contentXFactors.getFirst().factor().inCoeffDomain())
     contentXFactors.removeFirst();
@@ -97 +109 @@
 }
 
+/// factorize a squarefree bivariate polynomial over \f$ F_{p} \f$.
+///
+/// @return @a FpBiSqrfFactorize returns a list of monic factors, the first
+///         element is the leading coefficient.
+/// @sa FqBiSqrfFactorize(), GFBiSqrfFactorize()
+inline
+CFList FpBiSqrfFactorize (const CanonicalForm & G ///< [in] a bivariate poly
+                         )
+{
+  ExtensionInfo info= ExtensionInfo (false);
+  return biSqrfFactorizeHelper (G, info);
+}
+
 /// factorize a squarefree bivariate polynomial over \f$ F_{p}(\alpha ) \f$.
 ///
@@ -108 +133 @@
 {
   ExtensionInfo info= ExtensionInfo (alpha, false);
-  CFMap N;
-  CanonicalForm F= compress (G, N);
-  CanonicalForm contentX= content (F, 1);
-  CanonicalForm contentY= content (F, 2);
-  F /= (contentX*contentY);
-  CFFList contentXFactors, contentYFactors;
-  contentXFactors= factorize (contentX, alpha);
-  contentYFactors= factorize (contentY, alpha);
-  if (contentXFactors.getFirst().factor().inCoeffDomain())
-    contentXFactors.removeFirst();
-  if (contentYFactors.getFirst().factor().inCoeffDomain())
-    contentYFactors.removeFirst();
-  if (F.inCoeffDomain())
-  {
-    CFList result;
-    for (CFFListIterator i= contentXFactors; i.hasItem(); i++)
-      result.append (N (i.getItem().factor()));
-    for (CFFListIterator i= contentYFactors; i.hasItem(); i++)
-      result.append (N (i.getItem().factor()));
-    normalize (result);
-    result.insert (Lc (G));
-    return result;
-  }
-  mat_ZZ M;
-  vec_ZZ S;
-  F= compress (F, M, S);
-  CFList result= biFactorize (F, info);
-  for (CFListIterator i= result; i.hasItem(); i++)
-    i.getItem()= N (decompress (i.getItem(), M, S));
-  for (CFFListIterator i= contentXFactors; i.hasItem(); i++)
-    result.append (N(i.getItem().factor()));
-  for (CFFListIterator i= contentYFactors; i.hasItem(); i++)
-    result.append (N (i.getItem().factor()));
-  normalize (result);
-  result.insert (Lc(G));
-  return result;
+  return biSqrfFactorizeHelper (G, info);
 }
 
@@ -158 +148 @@
           "GF as base field expected");
   ExtensionInfo info= ExtensionInfo (getGFDegree(), gf_name, false);
-  CFMap N;
-  CanonicalForm F= compress (G, N);
-  CanonicalForm contentX= content (F, 1);
-  CanonicalForm contentY= content (F, 2);
-  F /= (contentX*contentY);
-  CFList contentXFactors, contentYFactors;
-  contentXFactors= biFactorize (contentX, info);
-  contentYFactors= biFactorize (contentY, info);
-  if (contentXFactors.getFirst().inCoeffDomain())
-    contentXFactors.removeFirst();
-  if (contentYFactors.getFirst().inCoeffDomain())
-    contentYFactors.removeFirst();
-  if (F.inCoeffDomain())
-  {
-    CFList result;
-    for (CFListIterator i= contentXFactors; i.hasItem(); i++)
-      result.append (N (i.getItem()));
-    for (CFListIterator i= contentYFactors; i.hasItem(); i++)
-      result.append (N (i.getItem()));
-    normalize (result);
-    result.insert (Lc (G));
-    return result;
-  }
-  mat_ZZ M;
-  vec_ZZ S;
-  F= compress (F, M, S);
-  CFList result= biFactorize (F, info);
-  for (CFListIterator i= result; i.hasItem(); i++)
-    i.getItem()= N (decompress (i.getItem(), M, S));
-  for (CFListIterator i= contentXFactors; i.hasItem(); i++)
-    result.append (N(i.getItem()));
-  for (CFListIterator i= contentYFactors; i.hasItem(); i++)
-    result.append (N (i.getItem()));
-  normalize (result);
-  result.insert (Lc(G));
-  return result;
+  return biSqrfFactorizeHelper (G, info);
 }