Changeset 8df5991 in git

Timestamp:

Dec 9, 2020, 1:51:10 PM (3 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'fieker-DuVal', '117eb8c30fc9e991c4decca4832b1d19036c4c65')(u'spielwiese', '38077648e7239f98078663eb941c3c979511150a')

Children:

4a1b76a2ee72e1a9605d599b5dbc8ca819d36de8

Parents:

fef0b200e27e566748aefee86ca6f0f32e2dd61b

Message:

fix: division for letterplace

File:

• kernel/polys.cc (modified) (4 diffs)

kernel/polys.cc

@@ -42 +42 @@
     return NULL;
   }
-  if ((pNext(q)!=NULL)||rIsNCRing(r))
+  if ((pNext(q)!=NULL)||rIsPluralRing(r))
   { /* This means that q != 0 consists of at least two terms*/
     if(p_GetComp(p,r)==0)
@@ -159 +159 @@
   }
   else
-  { /* This means that q != 0 consists of just one term */
+  { /* This means that q != 0 consists of just one term, or LetterPlace */
+#ifdef HAVE_RINGS
+    if (pNext(q)!=NULL)
+    {
+      WerrorS("division over a coefficient domain only implemented for terms");
+      return NULL;
+    }
+#endif
     return p_DivideM(p,q,r);
   }
@@ -177 +184 @@
     return NULL;
   }
-  if ((pNext(q)!=NULL)||rIsNCRing(r))
+  if ((pNext(q)!=NULL)||rIsPluralRing(r))
   { /* This means that q != 0 consists of at least two terms*/
     if(p_GetComp(p,r)==0)
@@ -295 +302 @@
        or that r is over a coefficient ring. */
 #ifdef HAVE_RINGS
-    if (!rField_is_Domain(r))
-    {
-      WerrorS("division only defined over coefficient domains");
-      return NULL;
-    }
     if (pNext(q)!=NULL)
     {