Changeset b2e2b0 in git

Timestamp:

Jul 3, 2020, 5:03:52 PM (4 years ago)

Author:

Max Horn <max@…>

Branches:

(u'fieker-DuVal', '117eb8c30fc9e991c4decca4832b1d19036c4c65')(u'spielwiese', 'b9f50b373314e74e83c7c060a651dd2913e1f033')

Children:

d0adb23686023dffa37da6380408f9f10d314ae4

Parents:

94479b06ea30b1f20ba9a730ece0083db571e984

git-author:

Max Horn <max@quendi.de>2020-07-03 17:03:52+02:00

git-committer:

Max Horn <max@quendi.de>2020-07-07 09:42:17+02:00

Message:

Fix a bunch of warnings

Files:

• Singular/dyn_modules/Order/nforder_ideal.cc (modified) (1 diff)
• Singular/dyn_modules/cohomo/cohomo.cc (modified) (2 diffs)
• Singular/dyn_modules/systhreads/bytebuf.h (modified) (1 diff)
• Singular/dyn_modules/systhreads/libthread.h (modified) (1 diff)
• Singular/dyn_modules/systhreads/shared.cc (modified) (2 diffs)
• Singular/eigenval_ip.cc (modified) (1 diff)
• Singular/svd_si.h (modified) (6 diffs)
• factory/cf_gcd.cc (modified) (1 diff)

Singular/dyn_modules/Order/nforder_ideal.cc

@@ -311 +311 @@
   } else if (i<0) {
     Werror("not done yet");
+    return NULL;
   } else {
     nforder_ideal *B = nf_idPower(A, i/2);

Singular/dyn_modules/cohomo/cohomo.cc

@@ -1313 +1313 @@
     {
       fset.erase(fset.begin()+i);
-      return fset;
-    }
-  }
+      break;
+    }
+  }
+  return fset;
 }
 
@@ -4135 +4136 @@
   for(int i=0;i<bvs.size();i++)
   {
-    for(int j=0;j<bvs.size(), j!=i; j++)
+    for(int j=0;j!=i; j++)
     {
       vs.push_back(bvs[j]);

Singular/dyn_modules/systhreads/bytebuf.h

@@ -33 +33 @@
     buf = allocate_space(cap);
     memcpy(buf, other.buf, count);
+    return *this;
   }
   ~ByteBuf() {

Singular/dyn_modules/systhreads/libthread.h

@@ -25 +25 @@
   Job *startJob(ThreadPool *pool, Job *job, leftv arg);
   Job *startJob(ThreadPool *pool, Job *job);
-  Job *scheduleJob(ThreadPool *pool, Job *job, long ndeps, Job **deps);
+//   Job *scheduleJob(ThreadPool *pool, Job *job, long ndeps, Job **deps);
   void cancelJob(Job *job);
   void waitJob(Job *job);

Singular/dyn_modules/systhreads/shared.cc

@@ -1480 +1480 @@
   ts->active = false;
   thread_lock.unlock();
+  return result;
 }
 
@@ -2492 +2493 @@
 }
 
-Job *scheduleJob(ThreadPool *pool, Job *job, long ndeps, Job **deps) {
-  if (job->pool) return NULL;
-  pool->scheduler->lock.lock();
-  bool cancelled = false;
-  job->addDep(ndeps, deps);
-  for (long i = 0; i < ndeps; i++) {
-    deps[i]->addNotify(job);
-    cancelled |= deps[i]->cancelled;
-  }
-  if (cancelled) {
-    job->pool = pool;
-    pool->cancelJob(job);
-  }
-  else
-    pool->attachJob(job);
-  pool->scheduler->lock.unlock();
-}
+// Job *scheduleJob(ThreadPool *pool, Job *job, long ndeps, Job **deps) {
+//   if (job->pool) return NULL;
+//   pool->scheduler->lock.lock();
+//   bool cancelled = false;
+//   job->addDep(ndeps, deps);
+//   for (long i = 0; i < ndeps; i++) {
+//     deps[i]->addNotify(job);
+//     cancelled |= deps[i]->cancelled;
+//   }
+//   if (cancelled) {
+//     job->pool = pool;
+//     pool->cancelJob(job);
+//   }
+//   else
+//     pool->attachJob(job);
+//   pool->scheduler->lock.unlock();
+//   return FIXME: missing/unclear what this is supposed to be
+// }
 
 void cancelJob(Job *job) {

Singular/eigenval_ip.cc

@@ -216 +216 @@
       else
       {
-        if(e->m[i0]==NULL&&!nGreaterZero(pGetCoeff(e->m[i1]))||
-           e->m[i1]==NULL&&
-          (nGreaterZero(pGetCoeff(e->m[i0]))||pNext(e->m[i0])!=NULL)||
+        if((e->m[i0]==NULL&&!nGreaterZero(pGetCoeff(e->m[i1])))||
+           (e->m[i1]==NULL&&
+            (nGreaterZero(pGetCoeff(e->m[i0]))||pNext(e->m[i0])!=NULL))||
            e->m[i0]!=NULL&&e->m[i1]!=NULL&&
-          (pNext(e->m[i0])!=NULL&&pNext(e->m[i1])==NULL||
-           pNext(e->m[i0])==NULL&&pNext(e->m[i1])==NULL&&
-           nGreater(pGetCoeff(e->m[i0]),pGetCoeff(e->m[i1]))))
+            ((pNext(e->m[i0])!=NULL&&pNext(e->m[i1])==NULL)||
+             (pNext(e->m[i0])==NULL&&pNext(e->m[i1])==NULL&&
+             nGreater(pGetCoeff(e->m[i0]),pGetCoeff(e->m[i1])))))
         {
           poly e1=e->m[i0];

Singular/svd_si.h

@@ -3225 +3225 @@
             return;
         }
-        ap::ap_error::make_assertion(fromtheright && zcolumns==m || !fromtheright && zrows==m);
+        ap::ap_error::make_assertion(fromtheright ? zcolumns==m : zrows==m);
 
         //
@@ -3452 +3452 @@
             return;
         }
-        ap::ap_error::make_assertion(fromtheright && zcolumns==n || !fromtheright && zrows==n);
+        ap::ap_error::make_assertion(fromtheright ? zcolumns==n : zrows==n);
 
         //
@@ -3860 +3860 @@
             return;
         }
-        ap::ap_error::make_assertion(fromtheright && zcolumns==m || !fromtheright && zrows==m);
+        ap::ap_error::make_assertion(fromtheright ? zcolumns==m : zrows==m);
 
         //
@@ -4075 +4075 @@
             return;
         }
-        ap::ap_error::make_assertion(fromtheright && zcolumns==n || !fromtheright && zrows==n);
+        ap::ap_error::make_assertion(fromtheright ? zcolumns==n : zrows==n);
 
         //
@@ -6897 +6897 @@
                 // First apply standard test to bottom of matrix
                 //
-                if( amp::abs<Precision>(e(m-1))<=amp::abs<Precision>(tol)*amp::abs<Precision>(d(m)) || tol<0 && amp::abs<Precision>(e(m-1))<=thresh )
+                if( amp::abs<Precision>(e(m-1))<=amp::abs<Precision>(tol)*amp::abs<Precision>(d(m)) || (tol<0 && amp::abs<Precision>(e(m-1))<=thresh) )
                 {
                     e(m-1) = 0;
@@ -6937 +6937 @@
                 // First apply standard test to top of matrix
                 //
-                if( amp::abs<Precision>(e(ll))<=amp::abs<Precision>(tol)*amp::abs<Precision>(d(ll)) || tol<0 && amp::abs<Precision>(e(ll))<=thresh )
+                if( amp::abs<Precision>(e(ll))<=amp::abs<Precision>(tol)*amp::abs<Precision>(d(ll)) || (tol<0 && amp::abs<Precision>(e(ll))<=thresh) )
                 {
                     e(ll) = 0;

factory/cf_gcd.cc

@@ -101 +101 @@
   if ( getCharacteristic() != 0 )
   {
-    if (0) ; // dummy, to be able to build without NTL and FLINT
+    if (0) {} // dummy, to be able to build without NTL and FLINT
     #if defined(HAVE_FLINT) && ( __FLINT_RELEASE >= 20503)
     if ( isOn( SW_USE_FL_GCD_P)